isoftstone/lc_backend
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(job): remove redundant date filter conditions in SQL query

Browse Source 
- Removed duplicated and unnecessary date filtering logic in the SQL query
- Simplified the query structure by eliminating repetitive time range checks
- Ensured that the remaining date filtering is handled properly through parameter validation
- Improved code readability and maintainability by reducing complexity in the WHERE clause
This commit is contained in:
yang chen
2025-11-17 10:30:31 +08:00
parent ba19342fa9
commit b8bf23ec24
1 changed files with 2 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
jeelowcode-module/jeelowcode-module-biz/src/main/java/com/jeelowcode/module/biz/job/AlibabaWorkOrderJob.java
View File

@@ -420,72 +420,8 @@ public class AlibabaWorkOrderJob implements JobHandler {
" ) rwoe " + " ) rwoe " +
" GROUP BY " + " GROUP BY " +
" rwoe.\"RELATE_WORK_ORDER_ID\" " + " rwoe.\"RELATE_WORK_ORDER_ID\" " +
" ) rwoa ON mwoe.WORK_ORDER_ID = rwoa.RELATE_WORK_ORDER_ID " + " ) rwoa ON mwoe.WORK_ORDER_ID = rwoa.RELATE_WORK_ORDER_ID "
"WHERE " + );
" ( " +
" mwoe.GMT_MODIFIED BETWEEN TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 00:00:00' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" AND TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 23:59:59' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" ) " +
" OR ( " +
" mwoe.SUB_GMT_MODIFIED BETWEEN TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 00:00:00' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" AND TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 23:59:59' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" ) " +
" OR ( " +
" rwoa.GMT_MODIFIED BETWEEN TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 00:00:00' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" AND TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 23:59:59' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" ) " +
" OR ( " +
" rwoa.SUB_GMT_MODIFIED BETWEEN TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 00:00:00' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" AND TO_DATE( " +
" NVL( " +
" '2025-11-11 11:11:11', " +
" TO_CHAR(SYSDATE, 'YYYY-MM-DD') || ' 23:59:59' " +
" ), " +
" 'YYYY-MM-DD HH24:MI:SS' " +
" ) " +
" )");
// 如果时间参数存在并且合法，则添加时间条件 // 如果时间参数存在并且合法，则添加时间条件
if (StrUtil.equals("1", params) && Objects.nonNull(startTime) && Objects.nonNull(endTime) && startTime.isBefore(endTime)) { if (StrUtil.equals("1", params) && Objects.nonNull(startTime) && Objects.nonNull(endTime) && startTime.isBefore(endTime)) {
String formattedStart = LocalDateTimeUtil.format(startTime, FORMAT_YEAR_MONTH_DAY_HOUR_MINUTE_SECOND); String formattedStart = LocalDateTimeUtil.format(startTime, FORMAT_YEAR_MONTH_DAY_HOUR_MINUTE_SECOND);